Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
docs/partners.md:7 requires Marketing Team and Technical Steering Committee approval for partner removals, which needs human confirmation.
Review effort: Balanced
Findings: None
What changed in this PR
Removes DigitalOcean from Node.js partner listings following the end of its Open Source Credits Program.
Changes:
- Removes the partner entry and README acknowledgment.
- Deletes DigitalOcean logo components and exports.
- Generalizes a hosting comment without changing runtime behavior.
| File | Description |
|---|---|
| README.md | Removes DigitalOcean acknowledgment. |
| packages/ui-components/src/Icons/PartnerLogos/index.ts | Removes DigitalOcean import and export. |
| packages/ui-components/src/Icons/PartnerLogos/DigitalOcean/Logo.tsx | Deletes full logo component. |
| packages/ui-components/src/Icons/PartnerLogos/DigitalOcean/index.ts | Deletes logo component exports. |
| packages/ui-components/src/Icons/PartnerLogos/DigitalOcean/Favicon.tsx | Deletes favicon component. |
| apps/site/public/static/partners/constants.json | Removes DigitalOcean partner metadata. |
| apps/site/next.constants.mjs | Changes hosting comment to refer generically to a VPS. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9201 +/- ##
==========================================
- Coverage 86.06% 86.01% -0.05%
==========================================
Files 86 86
Lines 6041 6034 -7
Branches 358 358
==========================================
- Hits 5199 5190 -9
- Misses 838 840 +2
Partials 4 4 ☔ View full report in Codecov by Harness. |
be6a1ee to
84849ea
Compare
📦 Build Size ComparisonSummary
|
|
@digitalocean is extending its sponsorship of the build workloads for NodeJS. |
|
Please do not merge this. |
|
👍 Yep, saw the positive engagement from DigitalOcean overnight in the build issue, will keep following and hopefully we won't need this after all! |
sxa
left a comment
sxa
left a comment
There was a problem hiding this comment.
I know this is draft so shouldn't get merged but in line with what Ryan said I'm putting an explicit block on this for now while the situation is still being negotiated :-)
Description
DigitalOcean is no longer providing credits for Node.js, as they have ended their Open Source Credits Program, and so we should no longer be listing them as a partner.
I've included a patch changeset for the logo removal from UI components, though I suppose one could argue that is a breaking change? We can keep the logo around if that is an issue.
Validation
All references to DigitalOcean as a partner have been removed.
Related Issues
cc nodejs/build#4499
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.